Add a Twisted handler #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @juggernaut ! We'll review and get this merged. |
| self.remaining -= len(chunk) | ||
|
|
||
| def connectionLost(self, reason): | ||
| self.finished.callback(self.response) |
There was a problem hiding this comment.
Since Rollbar requires an HTTPS connection, I would add in the following check for OpenSSL:
try:
# Verify we can make HTTPS requests with Twisted.
# From http://twistedmatrix.com/documents/12.0.0/core/howto/ssl.html
from OpenSSL import SSL
except ImportError:
log.exception('Rollbar requires SSL to work with Twisted')
raise There was a problem hiding this comment.
Good catch, done.
|
Thanks for the review @coryvirok . I've made changes per your feedback. |
|
LGTM. Thanks! |
|
FYI - @juggernaut I found a couple of issues while doing more thorough tests for this. Changes here: #71 |
|
thanks for fixing those @coryvirok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of twisted services we want to report to rollbar. I figured it'd be useful to contribute if others are interested. It's cleaner to use twisted's async client instead of using the default 'thread' handler. I have modeled this after the Tornado handler. Please review. Thanks!