Fix memory leak in in history collection #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History is stored as a list of logger records. After determining the history for a given record, that history was then added to the record. This led to a tree of records. Even though the history in the logger was truncated, active records in the history would continue to point to inactive ones, and so on, causing a memory leak. Since the history field on record objects was only used within the _add_history method, convert it to a local variable, and kill the leak.
|
Thanks @jbowes! This looks good to me. @coryvirok can you think of any reason why we were storing the history inside the |
|
@brianr I cannot. I was surprised to read that code and see |
brianr
added a commit
that referenced
this pull request
Jan 5, 2015
Fix memory leak in in history collection
|
Released in 0.9.6. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History is stored as a list of logger records. After determining the
history for a given record, that history was then added to the record.
This led to a tree of records. Even though the history in the logger was
truncated, active records in the history would continue to point to
inactive ones, and so on, causing a memory leak.
Since the history field on record objects was only used within the
_add_history method, convert it to a local variable, and kill the leak.