Fix walk_trace_chain: change container for seen_exceptions #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
What if, for some reason, the exception is not hashable?
I ran into this problem using the library https://github.com/ecederstrand/exchangelib
Here's my pr ecederstrand/exchangelib#1097
I don't know why the author decided to do that. Asked the author, haven't received an answer yet. Anyway, it seems to me that it's worth providing for such a possibility.
Type of change
Checklists
Development
Code review