Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.argv does not exist in some environments where the Python interpreter is embedded. #131

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

aren
Copy link
Contributor

@aren aren commented Sep 13, 2016

No description provided.

@aren
Copy link
Contributor Author

aren commented Feb 10, 2017

@coryvirok, this implements your feedback from PR #130. If it needs something else before you can merge, please let me know.

@ezarowny
Copy link
Contributor

This is pretty interesting. Which environment are you testing on?

@aren
Copy link
Contributor Author

aren commented Feb 10, 2017

I think this is an issue anywhere the python interpreter is embedded (https://docs.python.org/3/extending/embedding.html). In our case, it's this extension to FreeRADIUS (https://github.com/FreeRADIUS/freeradius-server/blob/v4.0.x/src/modules/rlm_python/rlm_python.c).

@brianr brianr merged commit 607c95f into rollbar:master Feb 10, 2017
@brianr
Copy link
Member

brianr commented Feb 10, 2017

Thanks @aren!

@ezarowny
Copy link
Contributor

@aren I'll cut a release of pyrollbar containing this change sometime this afternoon. Thanks for your pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants