ignore logs from Rollbar within RollbarHandler #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,6 +66,9 @@ def setHistoryLevel(self, level): | |||
| logging.Handler.setLevel(self, level) | |||
|
|
|||
| def emit(self, record): | |||
| if record.name == 'rollbar': | |||
There was a problem hiding this comment.
For good measure, how about if we also hardcode the name of the logger in rollbar/__init__.py to be the string "rollbar"? (Will make it more greppable.)
There was a problem hiding this comment.
That should work just fine I'd imagine.
There was a problem hiding this comment.
Added a constant for the pyrollbar log name.
|
👍 |
| @@ -68,6 +66,9 @@ def setHistoryLevel(self, level): | |||
| logging.Handler.setLevel(self, level) | |||
|
|
|||
| def emit(self, record): | |||
| if record.name == rollbar.__log_name__: | |||
There was a problem hiding this comment.
Can you add a comment explaining why this code is here?
There was a problem hiding this comment.
That would be wise :D
ezarowny
force-pushed
the
make-infinite-loop-finite
branch
from
98f5743 to
1d2ad27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve an infinite loop when a connection cannot be established to rollbar.com.