Convert to Go Modules and standardize package structure #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Go modules are now production ready * https://golang.org/doc/go1.14#introduction * This lowers the overhead of adding new contributors to the project, as they do not have to setup or work in GOPATH * This change also makes builds deterministic, as `go.mod` + `go.sum` pin package versions * a few package imports had to change slightly. In addition I took a pass of all files using `gofmt` * added a `.gitignore` * also updated the README.md * numbered lists can all just be `1.` but still render in an ascending list. This prevents the need to widely refactor to maintain ordering * updated the instructions on running and testing
|
The reason for the 1k diff (apologies btw) is because the project wasn't formatted via It's easy to run and it's built in.
Its the de facto way Go code is formatted both inside and outside of Google. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod+go.sumpin package versionsgofmt.gitignore1.but still render in an ascending list. This prevents the need to widely refactor to maintain ordering