addresses regression that prevents stubCall allowing non-function ret… #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdp
reviewed
Jun 11, 2024
| m.assertEqual(expectedKeyNameConfig2, resultKeyName) | ||
| end function | ||
|
|
||
| @ignore("this is not supported - we do not support mocking singleton objects between test runs") |
There was a problem hiding this comment.
Suggested change
| @ignore("this is not supported - we do not support mocking singleton objects between test runs") | |
| @ignore("this is not supported - we do not support mocking singleton objects between test runs") |
chrisdp
reviewed
Jun 11, 2024
Comment on lines
1835
to
1837
| if not type(stubOrReturnValue).endsWith("Function") | ||
| throw "Did not provide a stub function" | ||
| ' throw "Did not provide a stub function" | ||
| end if |
There was a problem hiding this comment.
we could just delete this now.
chrisdp
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urn values