Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed async tests sometimes waiting the full timeout even though the … #276

Merged
merged 1 commit into from
Feb 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion framework/src/source/TestRunner.bs
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ namespace rooibos
timeout = testSuite.asyncTimeout = invalid ? 60000 : testSuite.asyncTimeout

? "Waiting max " timeout "ms for the test suite to finish"
m.waitForField(node, "rooibosSuiteFinished", 10, timeout / 10)
t = createObject("roTimespan")
while node.rooibosSuiteFinished = false
m.wait(10)
if t.totalMilliseconds() >= timeout
exit while
end if
end while
end if
end if
nodeResults = node.asyncRooibosTestResult
Expand Down