Reduce raw code statements #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-code-statements
georgejecook
requested changes
Jan 21, 2024
There was a problem hiding this comment.
Agree with everything here, in principal; but want to get the other 2 prs in, an this one merged and 💯 ready, and play with it locally. Will pm you on slack tomorrow, to follow up, @chrisdp
| @@ -79,29 +77,53 @@ export class MockUtil { | |||
| return; | |||
| } | |||
|
|
|||
| let isDisabledFoMocking = functionStatement.annotations?.find(x => x.name.toLowerCase() === 'disablemocking'); | |||
There was a problem hiding this comment.
is this a part of another pr? I'm happy with it; but it seems beyond the scope of this prs description.
…w-code-statements
|
@georgejecook all the PRs I have open are branches of each other so you should be able to just test on #254 as it was the last one that was branched. |
chrisdp
merged commit ed3d6b6
into
rokucommunity:reduce-raw-code-statements
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #250
Removes some usages of raw code statements fixing tons of oddities in tests related to indentation issues. Also cleans up a lot of the tests so that they are now all testing the saw way rather then some stripping all indentations and others not doing this.