Skip to content

Commit

Permalink
Bugfix/general fixes (#284)
Browse files Browse the repository at this point in the history
* Fixed error log printing when it shouldn't

* Fixed a bug where asyn tests that finish sync could result in problems

* insure object key order when converting to string

* increased sleep at the end of the run to better flush the io logs
  • Loading branch information
chrisdp authored Jun 19, 2024
1 parent 9b04568 commit ee9bf4f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions framework/src/source/BaseTestSuite.bs
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ namespace rooibos
m.testRunner.top.unobserveFieldScoped("rooibosGroupFinished")
' m.testGroupDone()
m.onAsyncGroupComplete(group)
else if m.testRunner.top.rooibosGroupFinished
m.onAsyncGroupComplete(group)
end if

end if
Expand Down
4 changes: 3 additions & 1 deletion framework/src/source/CommonUtils.bs
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,9 @@ namespace rooibos.common
'bs:disable-next-line
isFirst = false
end if
for each key in input
keys = input.keys()
keys.sort()
for each key in keys
if rooibos.common.canSafelyIterateAAKey(input, key)
text = text + key + ":" + rooibos.common.asString(input[key], includeType)
end if
Expand Down
2 changes: 1 addition & 1 deletion framework/src/source/Rooibos.bs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace rooibos
' leading to an instant exit of the application

' Give the io port time to finish sending all the logs
sleep(200)
sleep(400)
end
end if
end if
Expand Down
1 change: 1 addition & 0 deletions framework/src/source/TestRunner.bs
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ namespace rooibos
? "Running suite asynchronously!"
m.nodeContext.top.observeFieldScoped("rooibosSuiteFinished", "Rooibos_onTestSuiteComplete")
testSuite.run()
return invalid
else
? "Running suite synchronously!"
testSuite.run()
Expand Down

0 comments on commit ee9bf4f

Please sign in to comment.