Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure grep exit code is "0" #17

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: ensure grep exit code is "0" #17

merged 1 commit into from
Mar 10, 2021

Conversation

mustaphazorgati
Copy link
Collaborator

@mustaphazorgati mustaphazorgati commented Mar 10, 2021 •
edited by rokroskar
Loading

@mustaphazorgati mustaphazorgati mentioned this pull request Mar 10, 2021
Closed
@rokroskar rokroskar changed the title #16 grep now not returning exit code 1 for empty body fix: ensure grep exit code is "0" Mar 10, 2021
rokroskar
rokroskar approved these changes Mar 10, 2021
View reviewed changes
Copy link
Owner

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mustaphazorgati

@rokroskar rokroskar merged commit 1ba8de3 into rokroskar:master Mar 10, 2021
@rokroskar rokroskar mentioned this pull request Mar 10, 2021
Closed
This was referenced Mar 11, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: This now fails where previously it was working.
2 participants
@mustaphazorgati @rokroskar