Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript compilation issue #45 #46

Merged
merged 1 commit into from
Jul 22, 2018
Merged

Fix Typescript compilation issue #45 #46

merged 1 commit into from
Jul 22, 2018

Conversation

medington
Copy link

@medington medington commented Jul 21, 2018

- Disable new keyOf behavior in Typescript 2.9
- Upgrade to more recent redux-devtools-extension to fix
  missing reference to GenericStoreEnhancer
@rokoroku
Copy link
Owner

Good! But using Extract<> approach will be better than using keyofStringsOnly flag. I'd take over this :)

@rokoroku rokoroku changed the base branch from master to issue-45 July 22, 2018 08:02
@rokoroku rokoroku merged commit 3d02c23 into rokoroku:issue-45 Jul 22, 2018
@medington
Copy link
Author

@rokoroku Thanks! I took the easy route 😉. I like the simpleKeyOf wrapper you added. Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants