Make the name field in projects optional
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport for 7.4.x is here: #871 |
Comment on lines
+222
to
+225
| self.root_project | ||
| .name | ||
| .as_ref() | ||
| .expect("all top-level projects must have their name set") |
There was a problem hiding this comment.
Is this panic reachable?
There was a problem hiding this comment.
It shouldn't be. I gave it a separate warning just in case though.
There was a problem hiding this comment.
Cool, I'm approving this then and we'll have @osyrisrblx check out #871 before merging since that's the one that's shipping right now
kennethloeffler
approved these changes
Feb 21, 2024
kennethloeffler
pushed a commit
that referenced
this pull request
Feb 21, 2024
Unlike most of the other backports, this code couldn't be directly translated so it had to be re-implemented. Luckily, it is very simple. This implementation is a bit messy and heavy handed with potential panics, but I think it's probably fine since file names that aren't UTF-8 aren't really supported anyway. The original implementation is a lot cleaner though. The test snapshots are (almost) all identical between the 7.5 implementation and this one. The sole exception is with the path in the `snapshot_middleware::project` test, since I didn't feel like adding a `name` parameter to `snapshot_project` in this implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #858.
If a project is named
default.project.json, it acts as aninitfile and gains the name of the folder it's inside of. If it is named something other thandefault.project.json, it gains the name of the file with.project.jsontrimmed off. So e.g.foo.project.jsonbecomesfoo.