-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-time status about sync details #569
Conversation
Do users need to know how many changes have occurred in a given time period? I feel like just displaying "last synced just now" or "last synced 5 minutes ago" is enough. |
@OverHash The #418 issue specifically asked to know a count, and no one disagreed. That said, I do think that a simple last since readout would solve the most common use case put forth in the issue- it informs you that the plugin is still working. However, it's possible that there could be cases where it's only syncing partially, which wouldn't be exposed by just a timestamp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see nothing that could be improved on in terms of code, I think this should be merged as soon as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, thank you!
@@ -13,6 +13,26 @@ local BorderedContainer = require(Plugin.App.Components.BorderedContainer) | |||
|
|||
local e = Roact.createElement | |||
|
|||
local AGE_UNITS = { {31556909, "year"}, {2629743, "month"}, {604800, "week"}, {86400, "day"}, {3600, "hour"}, {60, "minute"}, } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"last synced one year ago" would be a pretty funny message to happen in practice
* Rough prototype of patch info display * Remove extra newline * Switch to binding * Update slower for older timestamps * Batch patches within a second of each other * Fix indentation * Less wasteful refresh hz * More apt variable name Co-authored-by: Lucien Greathouse <[email protected]>
Resolves #418.
Features: