Fix status code #334
Merged
Fix status code #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code here is getting the status code through an internal interface, rather than [what Rails itself does](https://github.com/rails/rails/search?q=status_code_for_exception). Let's use the public interface to ensure we get the right status code!
|
Great change, thanks! |
olleolleolle
pushed a commit
to olleolleolle/lograge
that referenced
this pull request
Jan 11, 2022
The code here is getting the status code through an internal interface, rather than [what Rails itself does](https://github.com/rails/rails/search?q=status_code_for_exception). Let's use the public interface to ensure we get the right status code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here is getting the status code through an internal interface, rather than what Rails itself does. Let's use the public interface to ensure we get the right status code!