Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
44383: opt: fix flaky delete_range test r=RaduBerinde a=RaduBerinde

Noticed a flake in this test. Sometimes the first `Get` doesn't show
up; I think it is for a namespace table so that makes sense. Fixing by
filtering better the relevant stuff.

Release note: None

Co-authored-by: Radu Berinde <[email protected]>
  • Loading branch information
craig[bot] and RaduBerinde committed Jan 25, 2020
2 parents 72ce657 + 6aea183 commit d5ffbf7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/sql/opt/exec/execbuilder/testdata/delete_range
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@ SET tracing = on,kv; DELETE FROM a; SET tracing = off
# Ensure that DelRange requests are chunked for DELETE FROM...
query TT
SELECT operation, message FROM [SHOW KV TRACE FOR SESSION]
WHERE message LIKE '%DelRange%' OR message LIKE '%sending batch%'
WHERE message LIKE '%DelRange%' OR message LIKE '%DelRng%'
----
dist sender send r26: sending batch 1 Get to (n1,s1):1
flow DelRange /Table/53/1 - /Table/53/2
dist sender send r28: sending batch 1 DelRng to (n1,s1):1
flow DelRange /Table/53/1/601/0 - /Table/53/2
dist sender send r28: sending batch 1 DelRng to (n1,s1):1
dist sender send r28: sending batch 1 EndTxn to (n1,s1):1

# Ensure that DelRange requests are autocommitted when DELETE FROM happens on a
# chunk of fewer than 600 keys.
Expand Down

0 comments on commit d5ffbf7

Please sign in to comment.