fix: backoff is not applied when retryStrategy.limit has been reached. …

…Fixes argoproj#7588 Signed-off-by: Rohan Kumar <[email protected]>
rohankmr414 · Apr 4, 2022 · a85501e · a85501e
1 parent 62e0a8c
commit a85501e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -901,7 +901,7 @@ func (woc *wfOperationCtx) processNodeRetries(node *wfv1.NodeStatus, retryStrate
 		}
 
 		// See if we have waited past the deadline
-		if time.Now().Before(waitingDeadline) {
+		if time.Now().Before(waitingDeadline) && int32(len(node.Children)) <= retryStrategy.Limit.IntVal {
 			woc.requeueAfter(timeToWait)
 			retryMessage := fmt.Sprintf("Backoff for %s", humanize.Duration(timeToWait))
 			return woc.markNodePhase(node.Name, node.Phase, retryMessage), false, nil