Add tests for null inputs for Cache.metaNamespaceKeyFunc and ReflectU…

…tils.objectMetadata
rohanKanojia · Apr 27, 2021 · bba93b2 · bba93b2
1 parent 58bc5df
commit bba93b2
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/informers/cache/CacheTest.java b/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/informers/cache/CacheTest.java
@@ -87,6 +87,7 @@ void testDefaultNamespaceKey() {
     Pod testPodObj = new PodBuilder().withNewMetadata().withName("test-pod4").withNamespace("default").endMetadata().build();
 
     cache.add(testPodObj);
+    assertEquals("", Cache.metaNamespaceKeyFunc(null));
     assertEquals("default/test-pod4", Cache.metaNamespaceKeyFunc(testPodObj));
     assertEquals("default/test-pod4", Cache.namespaceKeyFunc("default", "test-pod4"));
   }

diff --git a/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/utils/ReflectUtilsTest.java b/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/utils/ReflectUtilsTest.java
@@ -15,8 +15,10 @@
  */
 package io.fabric8.kubernetes.client.utils;
 
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
 import static org.junit.jupiter.api.Assertions.assertSame;
 
+import io.fabric8.kubernetes.api.model.ConfigMapBuilder;
 import org.junit.jupiter.api.Test;
 
 import io.fabric8.kubernetes.api.model.HasMetadata;
@@ -93,4 +95,40 @@ public void testInstanceOf() throws ReflectiveOperationException {
     assertSame(meta, ReflectUtils.objectMetadata(baz));
   }
 
+  @Test
+  void testObjectMetadataReturnsNullOnNull() throws ReflectiveOperationException {
+    // Given
+    Object input = null;
+
+    // When
+    ObjectMeta result = ReflectUtils.objectMetadata(input);
+
+    // Then
+    assertThat(result).isNull();
+  }
+
+  @Test
+  void testNamespaceReturnsValidNamespace() throws ReflectiveOperationException {
+    // Given
+    Object input = new ConfigMapBuilder().withNewMetadata().withNamespace("ns1").endMetadata().build();
+
+    // When
+    String result = ReflectUtils.namespace(input);
+
+    // Then
+    assertThat(result).isNotNull().isEqualTo("ns1");
+  }
+
+  @Test
+  void testNamespaceReturnsBlankNamespace() throws ReflectiveOperationException {
+    // Given
+    Object input = null;
+
+    // When
+    String result = ReflectUtils.namespace(input);
+
+    // Then
+    assertThat(result).isNotNull().isBlank();
+  }
+
 }