testscript: make it compile under Go 1.10 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Oct 16, 2018
testscript/exe.go
Outdated
| func (nopTestDeps) StartTestLog(w io.Writer) {} | ||
|
|
||
| func (nopTestDeps) StopTestLog() error { | ||
| return nil | ||
| } | ||
|
|
||
| // Note: WriteHeapProfile is not needed for Go 1.10. |
There was a problem hiding this comment.
shouldn't this rather be "needed to build on Go 1.10, but not actually useful"?
There was a problem hiding this comment.
yeah, I had the comment wrong. fixed.
Making it compile under earlier versions than 1.10 is a bit harder, so punt for now.
rogpeppe
force-pushed
the
005-go1.10-support
branch
from
39c6f49 to
eae7c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it compile under earlier versions than 1.10 is a bit
harder, so punt for now.