txtar: alias types to x/tools #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Mar 27, 2023
Although we can't quite use the x/tools/txtar implementation in its entirety (golang/go#59264 needs to be fixed first, and we implement some other functions that x/tools/txtar doesn't (yet?) have, we can at least alias its types, which makes it possible to work with other packages that use those types.
rogpeppe
force-pushed
the
038-txtar-alias-types
branch
2 times, most recently
from
592b676
to
9a713f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we can't quite use the x/tools/txtar implementation in its entirety (golang/go#59264 needs to be fixed first, and we implement some other functions that x/tools/txtar doesn't (yet?) have, we can at least alias its types, which makes it possible to work with other packages that use those types.