testscript: remove errgo dependency #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to use it and every dependency lost is good.
mvdan
approved these changes
Mar 9, 2022
|
This is great - thanks! FWIW, there are a couple places I would like to use go-internal but I’m not due to people’s sensitivities around dependencies (coupled with the broader issue of it’s not easy or broadly known how to differentiate test-only dependencies…) |
|
That’s also partly what caused me to investigate pkg/diff#26 (comment) (along with a nerd-sniping tweet from @myitcv)… … but I am progressively getting more off-topic – mainly just wanted to say thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to use it and every dependency lost is good.