Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port 'cmd/go: add mv and support "! cmp" in script tests' #153

Closed
myitcv opened this issue Jan 27, 2022 · 3 comments · Fixed by #168
Closed

Port 'cmd/go: add mv and support "! cmp" in script tests' #153

myitcv opened this issue Jan 27, 2022 · 3 comments · Fixed by #168
Assignees
@mvdan
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@myitcv
Copy link
Collaborator

myitcv commented Jan 27, 2022

From https://go-review.googlesource.com/c/go/+/380916
@myitcv myitcv added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 27, 2022
@myitcv myitcv changed the title Port "cmd/go: add mv and support "! cmp" in script tests" Port 'cmd/go: add mv and support "! cmp" in script tests' Jan 27, 2022
@mvdan
Copy link
Collaborator

mvdan commented Mar 12, 2022

I'll take a stab at this as I want ! cmp for https://github.com/burrowers/garble.

@mvdan mvdan self-assigned this Mar 12, 2022
mvdan added a commit to mvdan/go-internal that referenced this issue Jul 24, 2022
@mvdan
testscript: port "mv" and "! cmp" from upstream
62b62be 
Fixes rogpeppe#153.
@mvdan mvdan mentioned this issue Jul 24, 2022
Merged
mvdan added a commit to mvdan/go-internal that referenced this issue Aug 3, 2022
@mvdan
testscript: port "mv" and "! cmp" from upstream
16cbd15 
And update the docs, copying from upstream's docs at
cmd/go/testdata/script/README.

Fixes rogpeppe#153.
@mvdan mvdan closed this as completed in #168 Aug 4, 2022
@bitfield
Copy link
Contributor

Just one comment, and I realise this applies to upstream too: it's a little confusing that you can't mv files into a directory the same way you can with cp:

mkdir new

# works
cp a.txt b.txt new

# doesn't work
mv a.txt b.txt new

-- a.txt --
-- b.txt --

@myitcv
Copy link
Collaborator Author

myitcv commented Aug 13, 2022

Hmm I'd say that probably warrants a new issue to capture that. Feels like an oversight in the upstream implementation?

@bitfield bitfield mentioned this issue Aug 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdan mvdan

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testscript: port "mv" and "! cmp" from upstream mvdan/go-internal
3 participants
@bitfield @myitcv @mvdan