-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more methods #8
Conversation
Amazing @felipehertzer, thank you very much for your contributions! |
Let me first fix the SonarCloud integration. Then I will request you @felipehertzer to update your branch. |
@rogervila no worries, let me know. |
Modify to the next occurrence of a given modifier such as a day of the week. If no modifier is provided, modify to the next occurrence of the current day of the week.
@felipehertzer merge main into your branch to get the Sonarcloud integration fix. |
Hey @rogervila done! I will work in more functions and fixes, may we can check if worth we use camelCase or move to snake_case. Also if we should fix the name functions to the exact same name of the carbon functions in PHP. Thanks |
Thank you very much. Yes, snake_case is the python way to go for methods. I used camel case because the first idea was to mimic as much as possible the original PHP Carbon library, but since Python and PHP are different, I think it does not make sense now that the library is implemented. If you consider it worth it, we can move it to snake_case Anyway, I am releasing 0.2.0 with your current changes :) |
Hey, thanks for you project, I added more methods.