Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for linux/arm64 architecture #98

Closed
wants to merge 6 commits into from

Conversation

abemedia
Copy link

@abemedia abemedia commented Mar 29, 2021

This PR adds arm64 architecture (#97).
I was trying to also get armv7 to work but struggling so doing that as a separate PR (abemedia#1).

Edit: just realised my IDE reformatted your YAML.
Do you want me to revert old old formatting (i.e. 4 spaces indentation, not 2)?

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #98 (90d0fb9) into master (25d7afa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          12       12           
  Lines         414      414           
=======================================
  Hits          400      400           
  Misses          9        9           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d7afa...90d0fb9. Read the comment docs.

@abemedia abemedia marked this pull request as draft March 29, 2021 01:35
@abemedia abemedia marked this pull request as ready for review March 29, 2021 02:53
@abemedia abemedia changed the title Build for arm64 architecture Build for linux/arm64 architecture Mar 29, 2021
@rogchap
Copy link
Owner

rogchap commented Mar 31, 2021

Thanks for the PR @abemedia
Will look in more details soon (looks fine from first glance)
Note to self: I really need to fix the build to handle FOSSA so that PRs from forks work better.

@abemedia
Copy link
Author

Thanks for the PR @abemedia
Will look in more details soon (looks fine from first glance)
Note to self: I really need to fix the build to handle FOSSA so that PRs from forks work better.

Nice one @rogchap! Would you like me to add tests for arm64 by the way? Could be implemented using uraimo/run-on-arch-action.

Also, do you have any idea why this build for armhf is failing? Would love to also get armhf working as that's what my infrastructure is mainly made up of.

@rogchap
Copy link
Owner

rogchap commented Apr 9, 2021

Hey @abemedia

Code looks good. I've updated to fix the FOSSA issue.
Would be good to add test for linux arm64, just so that we have a full test suite.

Looking at the build error for armhf... it's using the -m32 flag which means it's trying to build for 32bit, so maybe getting getting messed up with 32 vs 64 bit libraries (don't know if this helps?)

@rogchap
Copy link
Owner

rogchap commented Apr 22, 2021

Hey @abemedia, Apologies, there has been a lot of work done for Windows static binary and upgrades to V8 that has added quite a few conflicts.

@epk epk mentioned this pull request Oct 25, 2021
@genevieve
Copy link
Collaborator

Closing since #223 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants