Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting/unsetting of V8 feature flags #96

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Allow setting/unsetting of V8 feature flags #96

merged 1 commit into from
Mar 23, 2021

Conversation

rogchap
Copy link
Owner

@rogchap rogchap commented Mar 23, 2021

As requested by @kuoruan
#76 (comment)

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #96 (5dd10d1) into master (a487634) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   96.50%   96.53%   +0.02%     
==========================================
  Files          11       11              
  Lines         401      404       +3     
==========================================
+ Hits          387      390       +3     
  Misses          9        9              
  Partials        5        5              
Impacted Files Coverage Δ
v8go.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a487634...5dd10d1. Read the comment docs.

@rogchap rogchap requested review from tmc and zwang March 23, 2021 06:42
Copy link
Collaborator

@zwang zwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang zwang merged commit 78eaa3d into master Mar 23, 2021
@zwang zwang deleted the flags branch March 23, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants