-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Value into the Object type #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 92.44% 93.86% +1.42%
==========================================
Files 9 10 +1
Lines 344 391 +47
==========================================
+ Hits 318 367 +49
+ Misses 19 17 -2
Partials 7 7
Continue to review full report at Codecov.
|
Nice, will this changes allow getting any object down the object tree and also override to set any object? Probably except overriding Global Object? |
Yes, you should be able to get and set any Object in the tree and the change would be reflected in the VM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments. LGTM
Basic casting of a Value to an Object (
val.AsObject()
) as well as converting Value to an Object (val.Object()
)Only covers a small subset of the Object API as described here: https://v8.github.io/api/head/classv8_1_1Object.html
Also includes converting an
ObjectTemplate
to anObject
with a given Context, and retrieving the Global Object from a Context.This allows for things like this at runtime: