Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aliases.jl file earlier #165

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Move aliases.jl file earlier #165

merged 1 commit into from
Sep 12, 2022

Conversation

Keno
Copy link
Contributor

@Keno Keno commented Sep 11, 2022

Something has started causing errors loading the package, because Base.join gets resolved before FilePathsBase.join gets defined. This is probably a julia bug, but as a workaround, for now, move the aliases.jl file earlier to define FilePathsBase.join earlier in the package.

Something has started causing errors loading the package, because
`Base.join` gets resolved before `FilePathsBase.join` gets defined.
This is probably a julia bug, but as a workaround, for now, move
the aliases.jl file earlier to define `FilePathsBase.join` earlier
in the package.
@Keno
Copy link
Contributor Author

Keno commented Sep 11, 2022

@rofinn It'd be great to get this in ASAP and tag a new patch version. The julia base fix will probably take a while, because this is longstanding behavior that happened to get exposed by an inference change. Unfortunately, since so many packages depend on this, this means large portions of the ecosystem are currently broken without this change.

@Keno
Copy link
Contributor Author

Keno commented Sep 11, 2022

(In particular, the base issue is JuliaLang/julia#14055)

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #165 (24643ac) into master (bc65354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          12       12           
  Lines        1245     1245           
=======================================
  Hits         1145     1145           
  Misses        100      100           
Impacted Files Coverage Δ
src/FilePathsBase.jl 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rofinn
Copy link
Owner

rofinn commented Sep 12, 2022

Okay, running the CI now. If CI passes I don't see an issue with merging and tagging this quickly. I'm surprised so many packages would depend on this directly, most packages I've updated are just to loosen the type constraints to handle either strings or filepaths 🤷🏻 Normally I also bump the release in the PRs, but I'll just do that on the main branch this time.

@rofinn rofinn merged commit e3dcdd3 into rofinn:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants