Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change _assign_virtual_account_1/2 URIs #126

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

dhoon-dev
Copy link
Contributor

resolves #125

Change _assign_virtual_account_1/2 URIs

@dhoon-dev dhoon-dev requested a review from roeniss as a code owner January 8, 2025 15:32
@dhoon-dev
Copy link
Contributor Author

Test

➜  dhlottery-api git:(main) PYTHONPATH=./src/ python3 src/dhapi/main.py assign-virtual-account
✅ 가상계좌를 할당했습니다.
❗️입금 전 계좌주 이름을 꼭 확인하세요.
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ 전용가상계좌                 ┃ 결제신청금액 ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ [케이뱅크] xxx-xxxx-xxx-xxxx │ 50,000 원    │
└──────────────────────────────┴──────────────┘

@roeniss
Copy link
Owner

roeniss commented Jan 9, 2025

확인했습니다. 감사합니다.

저는 기존 URL (nicepay) 로도 잘 되는데, 홈페이지 UI 로 진행해보니 새 URL (kbank) 로 진행이 되네요. 원래부터 고정 가상계좌를 쓰던 유저는 어느 쪽이든 잘 작동하나봅니다. PR 까지 올려주셔서 너무 감사합니다. v4.0.5 로 배포하겠습니다.

@roeniss
Copy link
Owner

roeniss commented Jan 9, 2025

머지 전에 린팅을 한 번 해야할 것 같습니다. 혹시 아래 작업을 부탁드려도 될까요? 🙇 @dhoon-dev

pip3 install black pylint
make lintfmt
pip3 uninstall black pylint # optional
git add . 
git commit -m "chore: lintfmt"
git push

@roeniss roeniss removed their assignment Jan 9, 2025
@dhoon-dev
Copy link
Contributor Author

@roeniss

수정하지 않은 파일이 linting이 필요하든데, 저녁에 커밋 추가해두겠습니다.

@roeniss
Copy link
Owner

roeniss commented Jan 9, 2025

ruff 로 갈아탈까봐요

- router.py:
black reformatting.
- lottery_stdout_printer.py and lottery_client.py
fix R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
@roeniss roeniss merged commit 62bbd3b into roeniss:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assign-virtual-account 실패
2 participants