Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add #[doc(hidden)] for some constants #51

Merged
merged 1 commit into from
May 29, 2023
Merged

refactor: add #[doc(hidden)] for some constants #51

merged 1 commit into from
May 29, 2023

Conversation

bestgopher
Copy link
Contributor

@bestgopher bestgopher commented May 29, 2023

#50

@rodrimati1992
Copy link
Owner

rodrimati1992 commented May 29, 2023

I am surprised to discover this rustdoc bug in a PR to my own projects, but I'm fine accepting a PR to work around it.

Has this bug been reported? The bug being: "items declared inside expression blocks are included in the documentation".

@rodrimati1992
Copy link
Owner

Well, couldn't find a similar issue, so I created one: rust-lang/rust#112085

@rodrimati1992 rodrimati1992 merged commit eb8ffdd into rodrimati1992:master May 29, 2023
@bestgopher
Copy link
Contributor Author

bestgopher commented May 30, 2023

I'm also pleasantly surprised, but I haven't taken into account that this is an issue with rustdoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants