Refactoring for eliminate utils package #47 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 68.44% 75.40% +6.95%
==========================================
Files 7 7
Lines 187 187
==========================================
+ Hits 128 141 +13
+ Misses 58 44 -14
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rodrigo-brito
requested changes
Oct 13, 2020
There was a problem hiding this comment.
Hi @HemantJoshi11, thank you for your contribution. Please, just fix the import order.
| @@ -2,11 +2,10 @@ package model | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/rodrigo-brito/gocity/lib/file" | |||
There was a problem hiding this comment.
ok. I will fix
|
Hi @HemantJoshi11, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring utils package to lib/file