Allow users to setup control repo #794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the ability to setup the common directories needed for working with rspec-puppet by extracting out the logic that shouldn't be happening in a control repo which is symlinking (see rodjek#607)
|
Working on tests to bring coverage back up |
|
@rodjek I am having trouble finding the tests for the |
DavidS
requested changes
Nov 9, 2020
There was a problem hiding this comment.
Hi @thatnerdjosh ,
thanks for your contribution. I'm less concerned about the coverage, and more about adding a short sentence to https://github.com/rodjek/rspec-puppet/blob/master/docs/documentation/setup/index.md that this also works for control-repos now (and what that means).
|
Hello @DavidS, This was so long ago, somehow it slipped my plate... I forgot what a control repo was or what this code was achieving. I'll take a look and then update the docs accordingly. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the ability to setup the common directories needed for
working with rspec-puppet by extracting out the logic that shouldn't be
happening in a control repo which is symlinking (see
#607)