Fix import from latest 1password. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank for this contribution. |
|
That’s a good question that I should have answered in the commit. Sorry about that.
1Password
Version 6.8.7 (687003)
Mac App Store
Mac OS version 10.13.3 (17D102)
Noteworthy: I tested only with “Logins”, no other kind of items were exported. No tests were run, I just ran it on my actual passwords and imported it to my actual vault.
Important: To get the labels included in the CSV I had to enable “Include Column Labels” while exporting.
… On 23 Feb 2018, at 19:49, Alex ***@***.***> wrote:
Hi, thank for this contribution.
For which version of 1password on which OS is this for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHbcZqZZGETa25mqTqS5nFyyGGEWJ2vlks5tXwg8gaJpZM4SQ3m_>.
|
|
Thanks for this, I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to match the latest labels in 1password export.