Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fumbles recovered for TD #715

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Mar 20, 2022

The fumbles recovered for TD field was incorrectly pointing to the yards recovered from fumble field.

Fixes #543, #629

Signed-Off-By: Robert Clark [email protected]

@roclark roclark added the bug Something isn't working label Mar 20, 2022
@roclark roclark added this to the Release 0.6.1 milestone Mar 20, 2022
@roclark roclark self-assigned this Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #715 (69486df) into master (1fd1387) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          56       56           
  Lines       13187    13187           
=======================================
  Hits        13180    13180           
  Misses          7        7           
Impacted Files Coverage Δ
sportsipy/nfl/constants.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd1387...69486df. Read the comment docs.

The fumbles recovered for TD field was incorrectly pointing to the yards
recovered from fumble field.

Signed-Off-By: Robert Clark <[email protected]>
@roclark roclark force-pushed the patch/change-fb-fumbles-rec-for-td branch from 257bb92 to 69486df Compare March 20, 2022 20:34
@roclark roclark merged commit fffb7c8 into master Mar 20, 2022
@roclark roclark deleted the patch/change-fb-fumbles-rec-for-td branch March 20, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the NFL constants file, fumbles_recovered_for_touchdown is incorrect.
1 participant