Fixes to mmo= paywalls, multipaywalls, minor changes to item-paywall= #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ORENBT to item-paywall=.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Half on mmo= paywall=, multipaywall w/custom items, added IGNORENBT to item-paywall= for edge cases like spawner types ONLY WORKS ON NORMAL MATERIAL CHECKS
Half items should not happen with mmo= custom items in item paywalls anymore. This was caused by the main section checking before the mmo= section checked. Now it only checks mmo= if its an mmo= and does not continue to the main custom item check after.
Multipaywall was fixed due to custom model data not being taken into account on IsIdentical check.
IGNORENBT was added as a simple .contains check in item-paywall so that if you want to require spawners of any type in a spawner check it can work. ONLY WORKS ON NORMAL MATERIAL CHECKS NOT CUSTOM ITEM SECTIONS!
Also reduced version options for github down to last ingame editor version and latest cp version. Also added 1.20 as version selection.