Issue216 PostgreSQL 9.5 rockon

[Hooverdan96]

Net New.

Fixes #216

General information on project

This pull request proposes to add a new rock-on for the following project:

• name: PostgreSQL 9.5 (using official docker container)
• website: postgresql.org
• description: allow installation of PostgreSQL 9.5(.21) as a rockon, so it can be used by other applications that require a RDBMS.

Information on docker image

• docker image: https://hub.docker.com/_/postgres
• is an official docker image available for this project?: yes, this is the official docker image

Checklist

• Passes JSONlint validation
• Entry added to root.json in alphabetical order (for new rock-on only)
• "description" object lists and links to the docker image used
• "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
• "website" object links to project's main website

[Hooverdan96]

This is specific to Version 9.5. I had hoped, I could use a version-type environment variable to define a specific version, but I guess for this docker image (unlike a lot of the linuxserver images) only the "tag" is relevant. I don't believe that can be exposed during the configuration/installation in the Rockstor WebUI, but I think in the long run that would be a good idea, just so that we don't necessarily have to create separate Rockons for each version of a program (unless there are major changes between versions that would invalidate that approach).
I can open an issue for that separately.

[FroggyFlox]

Thanks a lot for this PR, @Hooverdan96 , I'll try to have a look at it as soon as I can.

I don't believe that can be exposed during the configuration/installation in the Rockstor WebUI, but I think in the long run that would be a good idea, just so that we don't necessarily have to create separate Rockons for each version of a program (unless there are major changes between versions that would invalidate that approach).

I completely agree with you, and that's also an idea that was brought up by @holmesb in his other postgres rock-on PR submission:
#190 (comment)

I started looking into it at the time but my time and focus got taken by our openSUSE rebase entirely so I haven't had time to properly work on it.

I can open an issue for that separately.

That would be great, yes, as I don't think one has been created for that already.

[Hooverdan96]

I opened an issue for the tag specification here:
#218

Let me know, if I should "refactor" it to make it more comprehensive/understandable.

[FroggyFlox]

Thanks a lot @Hooverdan96, that's perfect! You even clearly laid out a suggestion to be implemented so I don't see what else we could ask for.

[phillxnet]

@Hooverdan96 Thanks for presenting this pull request, much appreciated. We can back-port what we have here to the long outstanding posgresql 10.6 pr from @holmesb once we are all sorted with this on.

I think with these last few requested changes we should be sorted hopefully. Which would be great.

I've also tested as working access from another machine on the same network as the Rockstor machine thus:

psql --host=leap15-2.lan --port=5433 --username=post95admin
Password for user post95admin:                                                                                                                     
psql (10.10, server 9.5.21)                                                                                                                        
Type "help" for help.                                                                                                                              
                                                                                                                                                   
post95admin=# SELECT version();                                                                                                                    
                                                               version                                                                             
--------------------------------------------------------------------------------------------------------------------------------------             
 PostgreSQL 9.5.21 on x86_64-pc-linux-gnu (Debian 9.5.21-2.pgdg90+1), compiled by gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit              
(1 row)                                                                                                                                            
                                                                                                                                                   
post95admin=# \q 

[Hooverdan96]

@phillxnet, thanks for catching my description snafu and I agree with your suggestions on other changes. I hope, eventually we can replace this version of Postgres and the 10.6 one submitted by @holmesb with a generic rock-on that allows to select the version, like in some of the other RockOns. That way, we won't have a proliferations of RockOns just because of different versions (unless there's a compelling reason like it might be with ZoneMinder, but I am not sure whether that's true in that case).

[phillxnet]

@Hooverdan96 Thanks for the changes and totally agree with regard to current hack of hard wiring the tag. Would definitely be better to have a mechanism in place for this but given there's no 'standard' and each image can re-publish at any time with a different tag, and we don't really want folks to have to look up 'valid' tags we are sort of stuck for now. Plus, as you touched on, there is not always compatibility across tag versions. But we can do this bit by bit and hopefully implement elements of your Rock-on extension and then later extend this with @FroggyFlox idea or retrieving valid tags or the like.

But for the time being will just have to use what we have. Thanks again for stepping up to this one. I'll get it merged and hopefully pop in the required changes.

[phillxnet]

@Hooverdan96 Cheers. One last test, as-is and I get this one in hopefully.

[phillxnet]

@Hooverdan96 Your contributed Rock-on should now be published. Thanks for persevering and I look forward to us having a more flexible and capable Rock-on system as we develop.
Bit by Bit.