Skip to content

Commit

Permalink
Update React-RCTAppDelegate.podspec syntax error for USE_HERMES=1
Browse files Browse the repository at this point in the history
The `USE_HERMES` flag is set not escaped correctly by `React-RCTAppDelegate.podspec`, and it does not apply.

The flag needs to be defined as `USE_HERMES\=1`, but is currently set as `USE_HERMES`.

Hopefully this will fix facebook#38193.
  • Loading branch information
rocketraman committed Aug 17, 2024
1 parent e881a11 commit 30ee6b3
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use_hermes = ENV['USE_HERMES'] == nil || ENV['USE_HERMES'] == '1'

new_arch_enabled_flag = (is_new_arch_enabled ? " -DRCT_NEW_ARCH_ENABLED" : "")
is_fabric_enabled = true #is_new_arch_enabled || ENV["RCT_FABRIC_ENABLED"]
hermes_flag = (use_hermes ? " -DUSE_HERMES" : "")
hermes_flag = (use_hermes ? " -DUSE_HERMES\=1" : "")
other_cflags = "$(inherited) " + folly_compiler_flags + new_arch_enabled_flag + hermes_flag

header_search_paths = [
Expand Down

0 comments on commit 30ee6b3

Please sign in to comment.