Weather App (Ben) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const [hourlyData, setHourlyData] = useState(null); | ||
| const [error, setError] = useState(); | ||
|
|
||
| const handleChange = (event) => { |
There was a problem hiding this comment.
Dont need to wrap setCity in handleChange
| const handleChange = (event) => { | ||
| setCity(event.target.value); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can try to come back and add in a .env for practice
| .then((response) => response.data[0]) | ||
| .then((cityGeoData) => { | ||
| const cityData = cityGeoData; | ||
| return Promise.all([ |
There was a problem hiding this comment.
Great use of promise all to return a set of data and an API call
| <div>Temperature: {weatherData.main.feels_like}</div> | ||
| <div>Weather: {weatherData.weather[0].main}, {weatherData.weather[0].description}</div> | ||
| </div> : null } | ||
|
|
There was a problem hiding this comment.
Nice work getting the hourly data
| @@ -0,0 +1,41 @@ | |||
| import React from 'react' | |||
|
|
|||
There was a problem hiding this comment.
Great work creating this component well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.