V1 Update Metrics Exporter and deprecate SnapshotDelegation #708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnapshotDelegation
metrics-exporter.go
andsnapshot-collector.go
to support the new voting system.These are the values passed into Grafana:
No changes were needed for
activeProposals
andclosedProposals
.votesActiveProposals
andvotesClosedProposals
should display the correct info now thatcollector.delegateAddress
is replaced withcollector.signallingAddress
.We use
propMgr.GetArtifactsForVoting(blockNumber, address)
and pass the node address or on-chain delegate address to grabnodeVotingPower
anddelegateVotingPower
, similarly to how it's done inrp pdao status
One thing we could do is remove the
if time.Since(timestamp)>= hoursToWait
check on the voting power calls and have it run every 5 minutes alongside the task loop. It doesn't make calls to the Snapshot API so I think this is okay.