Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent truncation of user-settings.yml when disk is full by writing to /tmp first and moving the result to user-settings.yml #411

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Prevent truncation of user-settings.yml when disk is full by writing to /tmp first and moving the result to user-settings.yml #411

merged 2 commits into from
Nov 23, 2023

Conversation

jshufro
Copy link
Contributor

@jshufro jshufro commented Nov 22, 2023

closes #401

@jshufro
Prevent truncation of user-settings.yml when disk is full by writing …
23da043 
…to /tmp first and moving the result to user-settings.yml
0xfornax
0xfornax approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@0xfornax 0xfornax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks Patches!

@0xfornax 0xfornax merged commit b3e6b17 into rocket-pool:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfornax 0xfornax 0xfornax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] ~/.rocketpool/user-settings.yml gets truncated when the drive is full
2 participants
@jshufro @0xfornax