Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give option to generate wallet password #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angaz
Copy link
Contributor

@angaz angaz commented Mar 12, 2023

Closes #248

As pointed out in the issue, and from my understanding, the password is not used for any purpose other than during wallet init, and wallet restore, so giving the user an automatic way to generate the password would be nice.

I've added the functionality in a way that is least intrusive to the current flow, but I see no reason to prompt the user at all for the password. So if we want to remove the prompt completely, I will update the PR with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing user-created wallet password on wallet init
1 participant