Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove graphql variables, result, context attributes #289

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

danstarns
Copy link
Member

It's impractical to store the GraphQL arguments, results, and context due to their unpredictable sizes, which could lead to performance issues. Not only is storage unrealistic, but processing them for each field may result in excessive computation. Moreover, from a data protection standpoint, avoiding storage enhances security.

Related: #287

@danstarns
Copy link
Member Author

Initial benchmark before merge

rocket-connect/benchmarks@d5994af

@danstarns danstarns merged commit 57e1275 into main Apr 27, 2024
19 checks passed
@danstarns danstarns changed the title refactor: remove graphqlVariables, Result, Context refactor: remove graphql variables, tesult, context attributes May 28, 2024
@danstarns danstarns changed the title refactor: remove graphql variables, tesult, context attributes refactor: remove graphql variables, result, context attributes May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant