Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually set PATH and VIRTUAL_ENV for all binder related files #740

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Manually set PATH and VIRTUAL_ENV for all binder related files #740

merged 1 commit into from
Dec 29, 2023

Conversation

yuvipanda
Copy link
Contributor

Ref #739

@yuvipanda yuvipanda mentioned this pull request Dec 27, 2023
Closed
eitsupi
eitsupi approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

yuvipanda added a commit to 2i2c-org/utoronto-r-image that referenced this pull request Dec 28, 2023
@yuvipanda
Explicitly set VIRTUAL_ENV related env vars
8064aac 
Can be removed once rocker-org/rocker-versioned2#740
is merged
@yuvipanda yuvipanda mentioned this pull request Dec 28, 2023
Merged
@cboettig
Copy link
Member

nice, thanks both!

@cboettig cboettig merged commit 6efce3a into rocker-org:master Dec 29, 2023
1 check passed
@yuvipanda
Copy link
Contributor Author

Thanks @cboettig! Will this trigger a rebuild?

@cboettig
Copy link
Member

I triggered manual dispatch https://github.com/rocker-org/rocker-versioned2/actions/runs/7359142000

yuvipanda added a commit to 2i2c-org/utoronto-r-image that referenced this pull request Dec 29, 2023
@yuvipanda
Don't set $PATH and $VIRTUAL_ENV explicitly
5f9aaa3 
rocker-org/rocker-versioned2#740 has
been merged
@yuvipanda yuvipanda mentioned this pull request Dec 29, 2023
Merged
@cboettig cboettig mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

@cboettig cboettig Awaiting requested review from cboettig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuvipanda @cboettig @eitsupi