-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cli flag --prebuilt-platform
with --build-host
#6859
Conversation
cd13762
to
8383fd6
Compare
4521f92
to
85447ec
Compare
--prebuilt-platform
with --build-host
--prebuilt-platform
with --build-host
5f8ff89
to
61d6b5f
Compare
Signed-off-by: Luke Boswell <[email protected]>
61d6b5f
to
89d63f2
Compare
For this CI failure in nix-ubuntu... there is something going on between Nix and basic-cli. I'm going to ignore these tests (for linux) for this PR because we will be removing these in a follow-up as they are the only remaining basic-cli dependencies and prevent roc from moving ahead of the platform.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor stuff, but the shape is good.
This PR is a behemoth and has been cooking for many months. I'd vote that we continue to address feedback in a different PR, as every time I come back to this PR after a merge request, thousands of lines have to be re-read or re-skimmed.
That said, this was a Herculean task and everyone involved in this PR should be proud of their work!
crates/cli/tests/test-projects/algorithms/fibonacci-platform/host.zig
Outdated
Show resolved
Hide resolved
I already started with some cleanup before I read this, CI should be good though 🤞 |
Much love and gratitude @lukewilliamboswell @smores56 @r-bar ❤️ |
see #6859 for context Signed-off-by: Anton-4 <[email protected]>
This PR decouples roc from the host toolchains, by moving host rebuilding behind a compiler flag so it is no longer the default behaviour. It is still available where required using
--build-host
however will give a warning;This PR effectively removes platform rebuilding from the cli for end users -- while keeping some rebuilding functionality just for internal cli tests.
Application authors who use a release of a platform are not affected by this change. These users will continue to use a prebuilt platform.
After this change, platform authors will need to include a build script in their platform to build host binaries.
This change will make running platform example less convenient if they are not using a URL release, as the platform binaries will need to be built first in a separate step. For example this workflow;
roc build.roc
using host toolchain e.g.cargo
orzig
roc examples/hello-world.roc