Crate upgrades, fix ahash #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli_run::static_site_gen was hitting 'use of unstable library feature stdsimd' when compiling ahash. ahash was a dependency of hashbrown 0.13.2.
Anton-4
changed the title
Anton-4
commented
Dec 30, 2023
| hashbrown = { version = "0.13.2", features = ["bumpalo"] } | ||
| hashbrown = { version = "0.14.3" } |
There was a problem hiding this comment.
We were not using the bumpalo feature.
There was a problem hiding this comment.
I also thought at first that hashbrown 0.14.3 was no longer using ahash but I was wrong.
Anton-4
commented
Dec 30, 2023
| @@ -30,9 +30,6 @@ pub type SendMap<K, V> = im::hashmap::HashMap<K, V, BuildHasher>; | |||
|
|
|||
| pub type SendSet<K> = im::hashset::HashSet<K, BuildHasher>; | |||
|
|
|||
| // pub type BumpMap<'a, K, V> = hashbrown::HashMap<K, V, BuildHasher, hashbrown::BumpWrapper<'a>>; | |||
There was a problem hiding this comment.
The newest hashbrown no longer supports BumpWrapper, so uncommenting this code would not work anymore.
brian-carroll
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ahash compilation is broken on macos aarch64.
This PR makes us use ahash 0.8.6 and also does some other crate upgrades.