Use nix file set API to reduce how often we will need to rebuild #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton-4 <[email protected]>
|
Thanks for working on this @JRMurr :) |
Ahh my bad, will remove those. Good to review otherwise |
Anton-4
approved these changes
Dec 1, 2023
Anton-4
added a commit
that referenced
this pull request
Dec 1, 2023
rtfeldman
added a commit
that referenced
this pull request
Dec 1, 2023
Revert "Merge pull request #6113 from JRMurr/nix-build-file-sets"
|
I've reverted this PR @JRMurr, it sneaked through our CI, not yet sure how. It was hitting this issue, I'm not yet sure what exactly caused it. |
|
@Anton-4 ahh my bad thats a strange error, "in theory" my changes should only affect the nix build but not the dev env. Ill see if i can find a repro |
|
Ahh it was probably the flake update actually |
Not your fault, CI should have caught it |
That would be my guess as well |
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 2, 2023
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 2, 2023
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 12, 2023
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 14, 2023
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 15, 2023
JRMurr
added a commit
to JRMurr/roc
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some context https://roc.zulipchat.com/#narrow/stream/316715-contributing/topic/refactor.20nix.20files.2Fdefault.20build/near/404518156
What this is
This uses the new file set API (links at the bottom) for nix to reduce how many files we pass as the source to the nix builder for roc.
The bulk of the logic is is
nix/fileFilter.nix, I added comments above each filter to call out what it does but please let me know if I should explain more.TLDR of whats filtered
tests- we don't currently run tests in the nix build so they were not neededcratesfolder + a few files in the repo root like Cargo.{toml, lock}.md,.svg, and.pngWe can probably do more aggressive filtering especially if we refactor where we put the test only crates but I think this is a decent balance for now so if new crates/files are added people don't get weird errors they would not expect.
Misc changes
I had to update nixpkgs in the flake to get the new apis. I didnt notice any issues locally but might need someone to sanity check me
some links