Add simple download progress tracker #6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horriblename
force-pushed
the
feat-download-progress
branch
2 times, most recently
from
9eeadf8
to
96a5043
Compare
horriblename
force-pushed
the
feat-download-progress
branch
from
96a5043
to
7f82f8d
Compare
|
progress bar now prints this if we don't know the total size: otherwise this: |
bhansconnect
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5925
Adds a progress bar when downloading a platform
The progress bar looks like this:
It should be easy to use idicatif for a more graphical bar in the future, but I think this one is good enough