Queue up observe messages #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular data messages are queued when there are less than 100 messages for that client. Build finish messages are always enqueued. This ensures end messages are never lost, and enhances the user experience for the client as a busy build will drop less messages.
|
To me this looks fine. I was worried that there may be memory leaked, but the queue is very locally allocated in the client-loop, and thus this should be safe. I'll merge. We can reconsider if we encounter any issues. Thanks a lot! :) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 4, 2024
CHANGES: * improve documentation (robur-coop/builder#37 et al, fixes robur-coop/builder#27) * adapt to asn1-combinators 0.3.0 API: remove cstruct (robur-coop/builder#49 @hannesm) * queue up observe messages (robur-coop/builder#48 @reynir) * use "/job/_/build/_/main-binary" alias - eases bootstrapping (robur-coop/builder#42 @reynir) * drop platform: advice to shutdown workers (robur-coop/builder#39 @reynir) * FreeBSD: add builder_worker service script (robur-coop/builder#37 @hannesm) * client: enumerate valid periods in `--help` (robur-coop/builder#36 @reynir) * add an interval of "never" to never schedule a job (robur-coop/builder#34 @hannesm, fixes robur-coop/builder#32) * client: observe omit the UUID (robur-coop/builder#33 @hannesm)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * improve documentation (robur-coop/builder#37 et al, fixes robur-coop/builder#27) * adapt to asn1-combinators 0.3.0 API: remove cstruct (robur-coop/builder#49 @hannesm) * queue up observe messages (robur-coop/builder#48 @reynir) * use "/job/_/build/_/main-binary" alias - eases bootstrapping (robur-coop/builder#42 @reynir) * drop platform: advice to shutdown workers (robur-coop/builder#39 @reynir) * FreeBSD: add builder_worker service script (robur-coop/builder#37 @hannesm) * client: enumerate valid periods in `--help` (robur-coop/builder#36 @reynir) * add an interval of "never" to never schedule a job (robur-coop/builder#34 @hannesm, fixes robur-coop/builder#32) * client: observe omit the UUID (robur-coop/builder#33 @hannesm)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * improve documentation (robur-coop/builder#37 et al, fixes robur-coop/builder#27) * adapt to asn1-combinators 0.3.0 API: remove cstruct (robur-coop/builder#49 @hannesm) * queue up observe messages (robur-coop/builder#48 @reynir) * use "/job/_/build/_/main-binary" alias - eases bootstrapping (robur-coop/builder#42 @reynir) * drop platform: advice to shutdown workers (robur-coop/builder#39 @reynir) * FreeBSD: add builder_worker service script (robur-coop/builder#37 @hannesm) * client: enumerate valid periods in `--help` (robur-coop/builder#36 @reynir) * add an interval of "never" to never schedule a job (robur-coop/builder#34 @hannesm, fixes robur-coop/builder#32) * client: observe omit the UUID (robur-coop/builder#33 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular data messages are queued when there are less than 100 messages for that client. Build finish messages are always enqueued. This ensures end messages are never lost, and enhances the user experience for the client as a busy build will drop less messages.
The
morefunction depends onLwt_condition.signaldoes not yield so the function doesn't yield before the nextLwt_condition.waitthusmorenever misses a message.The number 100 is arbitrary chosen.
I tested on my builder setup, but I don't know how to reproduce missed messages.