Skip to content

Commit

Permalink
Cleaning up query param matching spec
Browse files Browse the repository at this point in the history
This is a small follow up to kubernetes-sigs#631 that addresses some of the tiny nits
that were leftover on that PR.
  • Loading branch information
robscott committed Apr 28, 2021
1 parent efd0246 commit 6558986
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
9 changes: 6 additions & 3 deletions apis/v1alpha1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,6 @@ type HTTPQueryParamMatch struct {
// expressions. Please read the implementation's documentation to determine
// the supported dialect.
//
// HTTP query parameter matching MUST be case-sensitive for both keys and
// values.
//
// +optional
// +kubebuilder:default=Exact
Type *QueryParamMatchType `json:"type,omitempty"`
Expand All @@ -372,6 +369,12 @@ type HTTPQueryParamMatch struct {
//
// Multiple match values are ANDed together, meaning, a request must match
// all the specified query parameters to select the route.
//
// HTTP query parameter matching MUST be case-sensitive for both keys and
// values. (See https://tools.ietf.org/html/rfc7230#section-2.7.3).
//
// Note that the query parameter key MUST always be an exact match by string
// comparison.
Values map[string]string `json:"values"`
}

Expand Down
10 changes: 6 additions & 4 deletions config/crd/bases/networking.x-k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6558986

Please sign in to comment.