Fetch attribute from SecurityTokenReference instead of from sitekey #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Thanks for this awesome package!
Instead of trying to grab the wsu id from a PHP
XMLSecurityKey
, it fetches the id of the last detected BinarySecurityToken.Moved the logic around so that it only gets executed if a BinarySecurityToken is available.
Note
Since this fallback functionality is currently not working (and hasn't been for a couple of years), I took the liberty of putting it behind an options flag as well.
The
KeyInfo
will only be created if you specifically ask for it. Thit allows for a more flexible way to apply key identifiers (similar to what you already have during signature)I've noticed in a few other tickets, you are looking for a better way to apply various key info types.
In a small wrapper I am working on, I moved it outside of the main logic as well so that you have a more flexible choice of which KeyIdentifier:
php-soap/psr18-wsse-middleware#5
This gives the flexibility