Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch attribute from SecurityTokenReference instead of from sitekey #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veewee
Copy link

@veewee veewee commented Mar 18, 2022

Fixes #61

Thanks for this awesome package!

Instead of trying to grab the wsu id from a PHP XMLSecurityKey, it fetches the id of the last detected BinarySecurityToken.
Moved the logic around so that it only gets executed if a BinarySecurityToken is available.

Note
Since this fallback functionality is currently not working (and hasn't been for a couple of years), I took the liberty of putting it behind an options flag as well.
The KeyInfo will only be created if you specifically ask for it. Thit allows for a more flexible way to apply key identifiers (similar to what you already have during signature)

I've noticed in a few other tickets, you are looking for a better way to apply various key info types.
In a small wrapper I am working on, I moved it outside of the main logic as well so that you have a more flexible choice of which KeyIdentifier:

php-soap/psr18-wsse-middleware#5

This gives the flexibility

$wsseMiddleware = new WsseMiddleware(
    outgoing: [
        new Entry\Timestamp(60),
        new Entry\BinarySecurityToken($pubKey),
        (new Entry\Signature(
            $privKey,
            new KeyIdentifier\BinarySecurityTokenIdentifier()
        )),
        (new Entry\Encryption(
            $signKey,
            new KeyIdentifier\X509SubjectKeyIdentifier($signKey)
        ))
    ],
    incoming: [
        new Entry\Decryption($privKey)
    ]
)

@veewee
Copy link
Author

veewee commented May 17, 2022

Hi @robrichards ,

I suspect you are very busy with other stuff.
Is there anything I can be in of assistence of in order to make some progress here?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem between encryptSoapDoc that calls addEncryptedKey
1 participant