Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalProject: Check all possible locations of RepositoryInfo.txt.in file to avoid problem with CMake 3.23 and release YCM 0.13.1 #393

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Mar 30, 2022

Fix robotology/robotology-superbuild#1074 .

CI is currently not working on this repo, so this branch will be tested in robotology/robotology-superbuild#1075 .

We also release YCM 0.13.1 with this change, to ensure that we have a version compatible with CMake 3.23 .

@traversaro traversaro changed the title ExternalProject: Vendor also RepositoryInfo.txt.in file to avoid problem with CMake 3.23 ExternalProject: Vendor also RepositoryInfo.txt.in file to avoid problem with CMake 3.23 and release YCM 0.13.1 Mar 30, 2022
@traversaro
Copy link
Member Author

CI is currently not working on this repo, so this branch will be tested in robotology/robotology-superbuild#1075 .

All hashes are failing with error:

   Downloading ExternalProject.cmake - ERROR 1: HASH mismatch: expected:
  c9d1167ae7730e9e6b1d9e9243a1f4f9bd9e2c5d actual:
  33dbf88a90f0774456ee9b303fe50fb587106892

@traversaro
Copy link
Member Author

CI is currently not working on this repo, so this branch will be tested in robotology/robotology-superbuild#1075 .

All hashes are failing with error:

   Downloading ExternalProject.cmake - ERROR 1: HASH mismatch: expected:
  c9d1167ae7730e9e6b1d9e9243a1f4f9bd9e2c5d actual:
  33dbf88a90f0774456ee9b303fe50fb587106892

Fixed by running ./tools/update_sha1sums.sh and committing the result in 6460520 .

@traversaro
Copy link
Member Author

traversaro commented Mar 30, 2022

Bootstrap is not working as we are not downloading also the RepositoryInfo.txt.in:

CMake Error: File /home/runner/work/robotology-superbuild/robotology-superbuild/build/CMakeFiles/RepositoryInfo.txt.in does not exist.
CMake Error at build/CMakeFiles/ExternalProject.cmake:2517 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  build/CMakeFiles/ExternalProject.cmake:3264 (_ep_add_download_command)
  build/CMakeFiles/YCMEPHelper.cmake:1038 (ExternalProject_Add)
  build/CMakeFiles/YCMEPHelper.cmake:1346 (ycm_ep_helper)
  cmake/YCMBootstrap.cmake:102 (ycm_bootstrap)
  CMakeLists.txt:58 (include)

As an alternative strategy, we can check both locations, either "${CMAKE_ROOT}/Modules/RepositoryInfo.txt.in" (CMake <= 3.22) or "${CMAKE_ROOT}/Modules/ExternalProject/RepositoryInfo.txt.in" (CMake >= 3.23), done in 8aa8bda .

@traversaro traversaro changed the title ExternalProject: Vendor also RepositoryInfo.txt.in file to avoid problem with CMake 3.23 and release YCM 0.13.1 ExternalProject: Check all possible locations of RepositoryInfo.txt.in file to avoid problem with CMake 3.23 and release YCM 0.13.1 Mar 30, 2022
@traversaro
Copy link
Member Author

Configuration in robotology/robotology-superbuild#1075 went fine, the fix is working.

@traversaro
Copy link
Member Author

As this is the fix to a serious failure that will affect users of robotology-superbuild, let's merge without further review as CI is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant